Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Correct the use of dist.all_reduce #2606

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Oct 12, 2022

新通信库下,通信后的结果会inplace的修改input,同时以task作为返回值。
在像下面的同步通信的语境下,不需要考虑返回的task。

@LiYuRio LiYuRio changed the base branch from release/2.6 to develop October 12, 2022 09:48
juncaipeng
juncaipeng previously approved these changes Oct 12, 2022
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiegegege xiegegege closed this Oct 12, 2022
@xiegegege xiegegege reopened this Oct 12, 2022
Copy link
Collaborator

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juncaipeng juncaipeng merged commit c4657cc into PaddlePaddle:develop Oct 13, 2022
@LiYuRio LiYuRio deleted the fix_all_reduce branch October 13, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants