Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] add -nc to 'wget' for skipping files already exist #713

Merged
merged 2 commits into from
Dec 22, 2023
Merged

[Doc] add -nc to 'wget' for skipping files already exist #713

merged 2 commits into from
Dec 22, 2023

Conversation

HydrogenSulfate
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate commented Dec 22, 2023 •
edited
Loading

PR types

Others

PR changes

Docs

Describe

  1. 所有文档中 wget 命令后面添加 -nc 参数，跳过已经存在的文件，防止多次执行时重复下载；curl 命令由于没有类似的功能因此不作改变。
  2. 将 math_module 里 Literal 改为兼容 python 3.7 写法

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 22, 2023

Thanks for your contribution!

zhiminzhang0830
zhiminzhang0830 previously approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 15ed976 into PaddlePaddle:develop Dec 22, 2023
@HydrogenSulfate HydrogenSulfate deleted the refine_download branch December 22, 2023 03:15
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
@HydrogenSulfate
[Doc] add -nc to 'wget' for skipping files already exist (PaddlePaddl…
54386fa 
…e#713)

* add -nc to 'wget' for skipping files already exist

* use typing_extensions instead of typing when import Literal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiminzhang0830 zhiminzhang0830 zhiminzhang0830 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HydrogenSulfate @zhiminzhang0830