Skip to content

Tipc fix #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 15, 2023
Merged

Tipc fix #253

merged 8 commits into from
Apr 15, 2023

Conversation

@wangguan1995
Copy link
Contributor

@wangguan1995 wangguan1995 commented Apr 13, 2023 •
edited
Loading

PR types

Bug fixes

PR changes

  • Fix bugs caused by changing examples' file structure
  • Fix TIPC file structure
  • Add [prepare] script of benchmark train
  • Update TIPC README

Describe

  1. put TIPC example input *.txt file in the new folder
  2. adapt to new example *.py training file path
  3. fix the bug : [data_download.py path] should be set in *.txt file not *.sh
  4. downloading and requirements installment are set in prepare.sh
  5. delete a parameter named SingleDP

@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

Thanks for your contribution!

@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

HydrogenSulfate
HydrogenSulfate reviewed Apr 13, 2023
View reviewed changes
test_tipc/configs/train_2d_unsteady_continuous/train_2d_unsteady_continuous.txt Outdated
Global.auto_cast:fp32
Global.epoch_num:benchmark_train=20
Global.save_model_dir:./output/
Global.©:./output/
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除特殊字符

test_tipc/configs/train_2d_unsteady_continuous/train_2d_unsteady_continuous.txt Outdated
model_name:cylinder2d_unsteady_train_newapi
python:python3.7
gpu_list:0
gpu_list:0:
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除冒号

@HydrogenSulfate HydrogenSulfate merged commit 40c7a43 into PaddlePaddle:develop Apr 15, 2023
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
@HydrogenSulfate
Merge pull request PaddlePaddle#253 from wangguan1995/tipc_fix
9125cb7 
Tipc fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HydrogenSulfate HydrogenSulfate HydrogenSulfate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangguan1995 @HydrogenSulfate