Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add a basic BuiltinVariable dispatch mechanism #157

Merged
merged 15 commits into from
Jun 15, 2023
Merged

add a basic BuiltinVariable dispatch mechanism #157

merged 15 commits into from
Jun 15, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Jun 13, 2023 •
edited
Loading

为 BuiltinVariable 添加转发机制，部分函数已经使用新的派发机制重新实现

@paddle-bot
Copy link

paddle-bot bot commented Jun 13, 2023

Thanks for your contribution!

@SigureMo SigureMo marked this pull request as draft June 13, 2023 12:41
@SigureMo SigureMo changed the title add a basic BuiltinVariable dispatcher mechanism add a basic BuiltinVariable dispatch mechanism Jun 14, 2023
@SigureMo SigureMo marked this pull request as ready for review June 15, 2023 03:21
SigureMo
SigureMo commented Jun 15, 2023
View reviewed changes
docs/design/builtin-dispatcher.md

> **Note**
>
> 我们现在代码中仍然有很多地方使用了旧的派发机制（利用 Python magic method 直接派发），这些将在之后逐步替换
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之后梳理一下可以考虑发几个任务～

@SigureMo SigureMo requested review from zrr1999 and gouzil June 15, 2023 04:48
@SigureMo
Copy link
Member Author

@zrr1999 @gouzil 也来瞅瞅这个 PR，涉及到一些机制，可能会影响之后代码的书写方式

Aurelius84
Aurelius84 previously approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2742195759
2742195759 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 8d62bb5 into develop Jun 15, 2023
@SigureMo SigureMo deleted the builtin-dispatch branch June 15, 2023 09:05
@SigureMo SigureMo mentioned this pull request Jun 22, 2023
Closed
@SigureMo SigureMo mentioned this pull request Aug 2, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@2742195759 2742195759 2742195759 approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@zrr1999 zrr1999 Awaiting requested review from zrr1999

@gouzil gouzil Awaiting requested review from gouzil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SigureMo @Aurelius84 @2742195759