Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reader.py #239

Merged
merged 14 commits into from
Oct 28, 2020
Merged

Update reader.py #239

merged 14 commits into from
Oct 28, 2020

Conversation

Qdriving
Copy link
Contributor

Random neg_item and random neg_cat is not paired, as usual even neg_item and neg_cat should be paired,

 Neg item and neg cat should be paried
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2020

CLA assistant check
All committers have signed the CLA.

yapf check
The condition that max length of hist_item_seq[batch_size][i] == 1 is not covered. But it is happened when I run the baseline of dien model.
yapf checked
yapf check
yapf check
yapf check
@MrChengmo
Copy link
Collaborator

可以装pre-commit修一下代码风格的问题:
image

@Qdriving
Copy link
Contributor Author

可以装pre-commit修一下代码风格的问题:
image

我在本地check是OK的,提交上来还是这样,搞不懂哦

pre-commit checked
@fuyinno4 fuyinno4 requested a review from yaoxuefeng6 October 10, 2020 01:30
@fuyinno4 fuyinno4 merged commit 904d21d into PaddlePaddle:master Oct 28, 2020
wangzhen38 pushed a commit to wangzhen38/PaddleRec that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants