Revert "update batch evaluate" #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b5c716c.
|
好的，我周日再检查下，之前测试是没有问题的，我在测下是什么问题 |
嗯嗯，辛苦啦~ 好像主要是postprocess里面加了一句concat，导致输出的格式和以前不一致了 |
|
我测试后发现，slide_predict的预测都没问题，predict的预测，当batchsize=1时，返回的是dict，但batchsize>1时，输入的img_file是list，因此输出的结果也是list，这是与slide_predict的接口相匹配的，如果把predict的输出结果全改成dict，slide_predict就会出错 |
|
请问确认分割和变化检测任务的slider_predict在batch_size > 1的情况下可以正常工作嘛？好像修改之后后处理返回的输出与我们在docstring和文档里说明的不太一样哦？ |
|
slider_predict没有返回值吧，只有输出的预测结果，我测试的slide_predict的预测都没问题 |
|
有问题的是predict，predict的输出结果是个list，因为batchsize>1时，输入的img_file是list |
|
|
|
好吧，看起来好像和我上次测试的时候发现的结论不太一样😂 也有可能是我那时候搞错了~ 辛苦试试看使用revert前的代码能不能通过单元测试，如果可以通过的话，可以重提一个PR revert我revert的那个commit~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #154
This is because the updates in #154 breaks the basic inference functionality of PaddleRS.