Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace imgaug with albumentations #13467

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GreatV
Copy link
Collaborator

@GreatV GreatV commented Jul 23, 2024

To support numpy 2.0, we need to remove the imgaug library and replace it with albumentations.

@jzhang533
Copy link
Collaborator

jzhang533 commented Jul 24, 2024

我们是不是讨论一下, 这个改动如何进一步测试?
现在在 github action 里的单测只是跑了推理, 但我理解这个功能主要是在训练时使用, 可能有必要做一下训练的回归测试,来确保没有问题。

方案一: 请百度的 QA 团队进行模型的回归测试。但我了解到的是,QA 团队目前的高优先级的事情是通过 paddlex 的入口集成了 paddleocr ,进行测试。 但是有个严重问题是, paddlex 里集成的是 paddleocr 2.6.1 branch, 这跟当前的 main 分支 diverge 严重, 所以对 paddlex 里集成的 paddleocr 进行了测试,也确保不了 main 分支的回归没有问题。
cc: @DDDivano @kolinwei

方案二: 补充使用到了这些功能的单测的 case, 添加到当前的 tests 下, 通过 github action 的 CI 来测试。

方案三: 不进行模型训练的回归测试, 等待版本发布后,社区来反馈是否有问题。

@GreatV
Copy link
Collaborator Author

GreatV commented Jul 24, 2024

准备先按方案二加点单测

@GreatV GreatV marked this pull request as draft July 29, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants