[Tokenizer] Add replace_additional_special_tokens parameter to add_special_tokens #9144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DrownFish19
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9144 +/- ##
========================================
Coverage 53.26% 53.26%
========================================
Files 652 652
Lines 105581 105606 +25
========================================
+ Hits 56237 56254 +17
- Misses 49344 49352 +8 ☔ View full report in Codecov by Sentry. |
lvdongyi
force-pushed
the
dev-20240914-add-special-token
branch
from
5388c5b to
20f9c6c
Compare
DrownFish19
reviewed
Sep 18, 2024
| encoder_dict[token] = len(self.encoder.keys()) | ||
| decoder_dict[len(self.decoder.keys())] = token | ||
| current_encoder_length = len(self.encoder) + len(self.added_tokens_encoder) | ||
| current_decoder_length = len(self.decoder) + len(self.added_tokens_decoder) |
There was a problem hiding this comment.
current_encoder_length 和 current_decoder_length 等价于len(self) ：包含所有speical token的vocab。
应该实现 def len() 方法，
def __len__(self):
return len(self.encoder) + len(self.added_tokens_encoder)| for idx, token in enumerate(token_list): | ||
| if token not in self.added_tokens_encoder: | ||
| encoder_dict[token] = current_encoder_length + idx | ||
| decoder_dict[current_decoder_length + idx] = token |
There was a problem hiding this comment.
如果token 在 self.added_tokens_encoder，token_id会不连续
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Description