Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast_ln spmd rules #9125

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

From00
Copy link
Collaborator

@From00 From00 commented Sep 11, 2024

PR types

Others

PR changes

Others

Description

注册fast_ln切分推导,对应规则实现PR:PaddlePaddle/Paddle#68148
为了避免mean和variance合并维度导致的“切两刀”问题,修改算子实现,保留多维的mean和variance。详见LayerNorm算子对类似问题的处理:PaddlePaddle/Paddle#58776

Copy link

paddle-bot bot commented Sep 11, 2024

Thanks for your contribution!

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.32%. Comparing base (d3302c5) to head (31e68d1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9125   +/-   ##
========================================
  Coverage    53.32%   53.32%           
========================================
  Files          652      652           
  Lines       105436   105436           
========================================
  Hits         56222    56222           
  Misses       49214    49214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit cd3dc95 into PaddlePaddle:develop Sep 13, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants