fix hang when Flag_dataloader_use_file_descriptor=True #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9080 +/- ##
===========================================
+ Coverage 53.44% 53.50% +0.06%
===========================================
Files 652 652
Lines 105187 105188 +1
===========================================
+ Hits 56214 56281 +67
+ Misses 48973 48907 -66 ☔ View full report in Codecov by Sentry. |
ZHUI
approved these changes
Sep 5, 2024
ckl117
pushed a commit
to ckl117/PaddleNLP
that referenced
this pull request
Sep 9, 2024
Mangodadada
pushed a commit
to Mangodadada/PaddleNLP
that referenced
this pull request
Sep 10, 2024
DrownFish19
reviewed
Sep 10, 2024
| @@ -750,14 +750,14 @@ def get_model_max_position_embeddings(config: PretrainedConfig) -> Optional[int] | |||
| return None | |||
|
|
|||
|
|
|||
| def read_res(model_name_or_path: str, tensor_queue: mp.Queue, result_queue: mp.Queue): | |||
| def read_res(model_name_or_path: str, tensor_queue: mp.Queue, result_queue: mp.Queue, done_event: mp.Event): | |||
| tokenizer = AutoTokenizer.from_pretrained(model_name_or_path) | |||
|
|
|||
| paddle.device.set_device("cpu") | |||
| paddle.disable_static() | |||
| outputs = [] | |||
| output_tensor = tensor_queue.get(timeout=1) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
修复开启Flag_dataloader_use_file_descriptor，导致test_predictor.py hang的问题