Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference] Fix weight_only_int4 bug #9073

Merged
merged 16 commits into from
Sep 4, 2024

Conversation

lixcli
Copy link
Contributor

@lixcli lixcli commented Sep 3, 2024

PR types

Bug fixes

PR changes

Others

Description

Fix weight_only_int4 bug

Copy link

paddle-bot bot commented Sep 3, 2024

Thanks for your contribution!

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.51%. Comparing base (4e7fb49) to head (5f49b75).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9073      +/-   ##
===========================================
- Coverage    53.56%   53.51%   -0.05%     
===========================================
  Files          652      652              
  Lines       106397   105187    -1210     
===========================================
- Hits         56987    56291     -696     
+ Misses       49410    48896     -514     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DesmonDay
Copy link
Contributor

代码库中很多地方有 weight_quant_method,麻烦全局确认一遍。

Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay merged commit 70da482 into PaddlePaddle:develop Sep 4, 2024
10 of 12 checks passed
@lixcli
Copy link
Contributor Author

lixcli commented Sep 4, 2024

代码库中很多地方有 weight_quant_method,麻烦全局确认一遍。

全局检查后发现argment.py里出现weight_quant_method重复,已在本次pr中删除重复的weight_quant_method字段

ckl117 pushed a commit to ckl117/PaddleNLP that referenced this pull request Sep 9, 2024
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants