Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moe save load #9045

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Fix moe save load #9045

merged 4 commits into from
Aug 30, 2024

Conversation

Meiyim
Copy link
Contributor

@Meiyim Meiyim commented Aug 29, 2024

PR types

PR changes

Description

Copy link

paddle-bot bot commented Aug 29, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.83%. Comparing base (a18e220) to head (53a1fad).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 80.00% 2 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9045      +/-   ##
===========================================
+ Coverage    53.58%   53.83%   +0.24%     
===========================================
  Files          652      652              
  Lines       105169   104520     -649     
===========================================
- Hits         56354    56265      -89     
+ Misses       48815    48255     -560     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 3ee8ab7 into PaddlePaddle:develop Aug 30, 2024
9 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* fix `upload signal` under pure dp and dp-moe (PaddlePaddle#8874)
---------

Co-authored-by: Ferrebo <kebo01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants