Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm]support pad to max_length & fix sp bug #9040

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

lugimzzz
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Copy link

paddle-bot bot commented Aug 28, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (3e7c5ca) to head (83a0b25).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9040      +/-   ##
===========================================
+ Coverage    53.76%   53.94%   +0.18%     
===========================================
  Files          652      652              
  Lines       104501   104929     +428     
===========================================
+ Hits         56186    56608     +422     
- Misses       48315    48321       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 7be1e16 into PaddlePaddle:develop Aug 29, 2024
10 of 12 checks passed
@lugimzzz lugimzzz deleted the max branch August 29, 2024 03:22
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* add sp hook

* support zero padding pad to max_length

* support finetune pad to max_length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants