Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel][PIR] Fit pir grad merge #8985

Merged
merged 19 commits into from
Sep 2, 2024

Conversation

AndSonder
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

现在 pir 的 grad merge 需要和开了 pp 一样,一次性喂进去一个 local_batch 的数据,原来 paddlenlp 在 program ir 下是给数据按照 batch 纬度分开了一次喂一个 micro batch 的数据,这样在 pir 下就会导致纬度不匹配

Copy link

paddle-bot bot commented Aug 22, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.83%. Comparing base (90863b1) to head (7b91a08).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 8 Missing ⚠️
paddlenlp/trainer/training_args.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8985      +/-   ##
===========================================
+ Coverage    53.49%   53.83%   +0.33%     
===========================================
  Files          655      652       -3     
  Lines       105463   104537     -926     
===========================================
- Hits         56419    56275     -144     
+ Misses       49044    48262     -782     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndSonder
Copy link
Contributor Author

目前 paddlenlp 的 grad_merge 和动转静和动态图 精度对不上,本 pr 暂时先不加单测,后续精度能对齐后补单测

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit e204b6d into PaddlePaddle:develop Sep 2, 2024
9 of 12 checks passed
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* fit pir llm grad merge

* fit code style

* add grad merge llama test

* Update run_pretrain_auto.py

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* Update ci_case_auto.sh

* remove test

* Update ci_case_auto.sh

* Update ci_case_auto.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants