fix llama3 static run #8849
Merged
fix llama3 static run #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8849 +/- ##
===========================================
+ Coverage 53.81% 53.87% +0.06%
===========================================
Files 652 652
Lines 104356 104356
===========================================
+ Hits 56155 56220 +65
+ Misses 48201 48136 -65 ☔ View full report in Codecov by Sentry. |
yuanlehome
force-pushed
the
fix_llama3_static_run
branch
from
e63c9b6
to
02680fa
Compare
wawltor
reviewed
Aug 28, 2024
paddlenlp/generation/utils.py
Outdated
| @@ -1407,6 +1407,7 @@ def _post_process_( | |||
| # compute next_tokens | |||
| if use_top_p: | |||
| logits = logits / temperature | |||
| probs = paddle.cast(probs, paddle.float32) | |||
There was a problem hiding this comment.
是不是在支持下top_p_sampling在bf16算子的支持？
There was a problem hiding this comment.
bf16算子kernel实现上是支持的，这里不cast成fp32是因为会报错
There was a problem hiding this comment.
我又确认了下，确实是kernel没有注册bf16，这个我在paddle侧支持了，所以这里添加cast的逻辑已移除，验证也没有问题
yuanlehome
force-pushed
the
fix_llama3_static_run
branch
from
02680fa
to
10d3e95
Compare
Mangodadada
pushed a commit
to Mangodadada/PaddleNLP
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
修复llama3散op静态图推理的一系列问题，精度正常