Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoE] Optimizer parameter broadcast #8810

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Function optimization

PR changes

Others

Description

Optimize broadcast_moe_optimizer to avoid out-of-memory situations.

Copy link

paddle-bot bot commented Jul 25, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 55.51%. Comparing base (77f6e98) to head (02378c7).
Report is 221 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/helper.py 4.34% 22 Missing ⚠️
paddlenlp/transformers/conversion_utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8810      +/-   ##
===========================================
+ Coverage    55.47%   55.51%   +0.04%     
===========================================
  Files          631      631              
  Lines        98466    98488      +22     
===========================================
+ Hits         54621    54677      +56     
+ Misses       43845    43811      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -115,7 +115,7 @@ def unwrap_optimizer(optimizer, optimizer_instances=()):

from paddlenlp.utils.safetensors import fast_load_file as safe_load_file

if sys.platform.startswith("cpu"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来是“cpu” ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有个合入PR我改错了

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 054c3ad into PaddlePaddle:develop Jul 26, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants