Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine savable #8758

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Refine savable #8758

merged 2 commits into from
Jul 19, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Jul 12, 2024

PR types

Others

PR changes

Others

Description

Others

Copy link

paddle-bot bot commented Jul 12, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (10d058d) to head (5d90395).
Report is 224 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/configuration_utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8758   +/-   ##
========================================
  Coverage    55.43%   55.43%           
========================================
  Files          626      626           
  Lines        98070    98071    +1     
========================================
+ Hits         54364    54365    +1     
  Misses       43706    43706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 57000fa into PaddlePaddle:develop Jul 19, 2024
10 of 12 checks passed
@ZHUI ZHUI deleted the refine_savable branch July 19, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants