Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct broken links in readme #8741

Merged

Conversation

jzhang533
Copy link
Collaborator

@jzhang533 jzhang533 commented Jul 10, 2024

其他我发现的 README.md 中的未修复bug:

  • 死链:例如,交互式教程那个链接,也没教程;精选模型库和多场景示例,都指向了 legacy 目录,是不是也需要更新链接(但我不知道新的链接在哪里)
  • 术语的混淆: 比如大模型工具链指向了链接 https://github.com/PaddlePaddle/PaddleNLP/tree/develop/llm ,但这里写的是大模型套件,所以读起来多少有些难以理解这两个术语。
  • pip install --pre --upgrade paddlenlp -f https://www.paddlepaddle.org.cn/whl/paddlenlp.html 这个命令我试了一下啊,装的是 3.0beta ,也不是装的 nightly build。
  • 社区交流,虽然,确实能够扫码进到微信群里,但是,那个问卷的问题有点莫名其妙,领到的大礼包,我看都是 2022年 5 月份的材料,不知道是否还有用,所以也不敢学。
  • 格式: 建议用 lint-md 统一一下格式,现在有的地方是中英文之间有空格的,有的地方没有。

Signed-off-by: Zhang Jun <jzhang533@gmail.com>
Copy link

paddle-bot bot commented Jul 10, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.70%. Comparing base (fbe613b) to head (6f5e235).
Report is 212 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8741   +/-   ##
========================================
  Coverage    55.70%   55.70%           
========================================
  Files          623      623           
  Lines        97399    97399           
========================================
  Hits         54255    54255           
  Misses       43144    43144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 3241120 into PaddlePaddle:develop Jul 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants