Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix #8730

Merged
merged 1 commit into from
Jul 9, 2024
Merged

bug fix #8730

merged 1 commit into from
Jul 9, 2024

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Jul 8, 2024 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Description

fix distributed allgather bug

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 8, 2024

Thanks for your contribution!

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.73%. Comparing base (bdd2287) to head (e5eeaa0).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/utils/distributed.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8730   +/-   ##
========================================
  Coverage    55.73%   55.73%           
========================================
  Files          623      623           
  Lines        97464    97464           
========================================
  Hits         54324    54324           
  Misses       43140    43140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wawltor
wawltor approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 595c2fb into PaddlePaddle:develop Jul 9, 2024
10 of 12 checks passed
FeixLiu added a commit to FeixLiu/PaddleNLP that referenced this pull request Jul 26, 2024
@FeixLiu
bug fix (PaddlePaddle#8730)
96c5236
gongel pushed a commit that referenced this pull request Jul 31, 2024
@FeixLiu @houj04
Cp 28 for xpu (#8812)
834649f 
* xpu use allgather (#8697)

* xpu use allgather

* xpu use allgather

* fix xpu gather for unified ckpt (#8710)

* bug fix (#8730)

* [XPU] use allgather and fp32 multinomial for XPU (#8787)

---------

Co-authored-by: houj04 <35131887+houj04@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeixLiu @wawltor