Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Broadcast optimizer state using broadcast_dp without shard-resh… #8522

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[fix] Broadcast optimizer state using broadcast_dp without shard-resh… #8522

merged 1 commit into from
Jun 3, 2024

Conversation

bo-ke
Copy link
Contributor

@bo-ke bo-ke commented May 31, 2024

…ard.

PR types

PR changes

Description

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 31, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented May 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented May 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.96%. Comparing base (e71540b) to head (a8d5fc1).
Report is 246 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 3 Missing ⚠️
paddlenlp/trainer/utils/helper.py 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8522      +/-   ##
===========================================
- Coverage    53.97%   53.96%   -0.01%     
===========================================
  Files          618      618              
  Lines        96825    96827       +2     
===========================================
- Hits         52260    52256       -4     
- Misses       44565    44571       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 440c093 into PaddlePaddle:develop Jun 3, 2024
7 of 12 checks passed
wawltor
wawltor reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bo-ke added a commit to bo-ke/PaddleNLP that referenced this pull request Jun 3, 2024
@bo-ke
[fix] Broadcast optimizer state using broadcast_dp without shard-resh…
6bc47e7 
…ard. (PaddlePaddle#8522)
DesmonDay pushed a commit that referenced this pull request Jun 3, 2024
@bo-ke
[fea] Cherry-picked MOE updates from develop (#8531)
4d33655 
* [fea] moe support (#8498)

Co-authored-by: kebo01 <kebo01@baidu.com>

* [fix] Broadcast optimizer state using broadcast_dp without shard-reshard. (#8522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor left review comments

Assignees

@DesmonDay DesmonDay

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bo-ke @CLAassistant @wawltor @DesmonDay