Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fused_ln:Added implementation for the HIP platform #8472

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

asr-sheep1
Copy link
Contributor

@asr-sheep1 asr-sheep1 commented May 21, 2024

PR types
New features

PR changes
Others

Description
added support for fused_rms to the HIP platform by macro definition 'PADDLE_WITH_HIP' .

Copy link

paddle-bot bot commented May 21, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.29%. Comparing base (87e4c4f) to head (fc4f528).
Report is 266 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8472      +/-   ##
===========================================
- Coverage    54.29%   54.29%   -0.01%     
===========================================
  Files          617      617              
  Lines        96339    96339              
===========================================
- Hits         52312    52305       -7     
- Misses       44027    44034       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asr-sheep1
Copy link
Contributor Author

@wj-Mcat 重新修改了对PR的描述,您可以帮我看一下,哪里还有需要修改的地方吗?CI-APPROVAL似乎不是由代码修改引起的错误,谢谢。

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 4c9a3f5 into PaddlePaddle:develop Jun 4, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants