Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rotary_emb for llama #8470

Merged
merged 1 commit into from
May 22, 2024
Merged

fix rotary_emb for llama #8470

merged 1 commit into from
May 22, 2024

Conversation

EnflameGCU
Copy link
Contributor

PR types

Bug fixes

PR changes

Models

Description

fix rotary_emb for llama

Copy link

paddle-bot bot commented May 20, 2024

Thanks for your contribution!

ZHUI
ZHUI previously approved these changes May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.28%. Comparing base (87e4c4f) to head (dd1e52b).
Report is 214 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 21.42% 11 Missing ⚠️
paddlenlp/transformers/llama/fusion_ops.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8470      +/-   ##
===========================================
- Coverage    54.29%   54.28%   -0.02%     
===========================================
  Files          617      617              
  Lines        96339    96352      +13     
===========================================
- Hits         52312    52308       -4     
- Misses       44027    44044      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ZHUI
ZHUI previously approved these changes May 20, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnflameGCU
Copy link
Contributor Author

EnflameGCU commented May 20, 2024

https://xly.bce.baidu.com/paddlepaddle/Paddle-NLP/newipipe/detail/10722223/job/26278757/realTimeLog/336
PaddleNLP-CI 由于用例import失败,看起来和本次修改没有关系,请 @ZHUI 帮忙确认和处理一下,十分感谢!

@ZHUI ZHUI closed this May 21, 2024
@ZHUI ZHUI reopened this May 21, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 621118e into PaddlePaddle:develop May 22, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants