Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix llama3 eot_id #8371

Merged
merged 1 commit into from
May 13, 2024
Merged

[BugFix] Fix llama3 eot_id #8371

merged 1 commit into from
May 13, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented May 7, 2024

PR types

Others

PR changes

Others

Description

fix as issue #8351

Copy link

paddle-bot bot commented May 7, 2024

Thanks for your contribution!

@ZHUI ZHUI mentioned this pull request May 7, 2024
1 task
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.43%. Comparing base (fdcabf8) to head (b58e05f).
Report is 10 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/tokenizer.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8371      +/-   ##
===========================================
+ Coverage    55.36%   55.43%   +0.06%     
===========================================
  Files          614      614              
  Lines        96016    96475     +459     
===========================================
+ Hits         53164    53480     +316     
- Misses       42852    42995     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI closed this May 8, 2024
@ZHUI ZHUI reopened this May 8, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 474aaaa into PaddlePaddle:develop May 13, 2024
7 of 9 checks passed
@ZHUI ZHUI deleted the fix/llama3 branch May 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants