Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixer (#8314) #8317

Merged
merged 1 commit into from
Apr 24, 2024
Merged

bug fixer (#8314) #8317

merged 1 commit into from
Apr 24, 2024

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Apr 24, 2024

PR types

Others

PR changes

Others

Description

修复非pp场景下,fp16 + delay loss scale + overlap bug

Copy link

paddle-bot bot commented Apr 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.10%. Comparing base (3cc32da) to head (a93ce88).
Report is 6 commits behind head on release/2.7.

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.7    #8317      +/-   ##
===============================================
- Coverage        57.16%   57.10%   -0.07%     
===============================================
  Files              586      586              
  Lines            88110    88269     +159     
===============================================
+ Hits             50368    50404      +36     
- Misses           37742    37865     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 8a6589c into PaddlePaddle:release/2.7 Apr 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants