Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Try except sequence parallel utils #8189

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Try except sequence parallel utils.

Copy link

paddle-bot bot commented Mar 26, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.37%. Comparing base (2273ee7) to head (696f305).
Report is 16 commits behind head on develop.

❗ Current head 696f305 differs from pull request most recent head cef772f. Consider uploading reports for the commit cef772f to get more accurate results

Files Patch % Lines
paddlenlp/transformers/__init__.py 50.00% 2 Missing ⚠️
paddlenlp/transformers/gpt/modeling.py 50.00% 2 Missing ⚠️
paddlenlp/transformers/gpt/modeling_pp.py 50.00% 2 Missing ⚠️
paddlenlp/transformers/llama/modeling.py 50.00% 2 Missing ⚠️
paddlenlp/transformers/mixtral/modeling.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8189      +/-   ##
===========================================
+ Coverage    55.15%   55.37%   +0.22%     
===========================================
  Files          601      601              
  Lines        91764    91781      +17     
===========================================
+ Hits         50611    50828     +217     
+ Misses       41153    40953     -200     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gongel
gongel previously approved these changes Apr 12, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,现在可以正确导包了

@wawltor wawltor merged commit 3566381 into PaddlePaddle:develop Apr 12, 2024
7 of 8 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Apr 15, 2024
DesmonDay added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants