Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Saving rng state not seed. #8185

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Mar 26, 2024

PR types

Bug fixe

PR changes

Others

Description

Saving rng state not seed.

Copy link

paddle-bot bot commented Mar 26, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.38%. Comparing base (b6dcb4e) to head (89c1ce4).
Report is 11 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8185      +/-   ##
===========================================
+ Coverage    55.37%   55.38%   +0.01%     
===========================================
  Files          596      601       +5     
  Lines        91622    91766     +144     
===========================================
+ Hits         50732    50823      +91     
- Misses       40890    40943      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 89bff20 into PaddlePaddle:develop Mar 26, 2024
7 of 10 checks passed
@ZHUI ZHUI deleted the trainer/fix_seed branch March 26, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants