Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sharding] Add arg of disabling sharding reduce_avg for accuracy verification #8168

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

haohongxiang
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

[sharding] Add arg of disabling sharding reduce_avg for accuracy verification

Copy link

paddle-bot bot commented Mar 21, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 55.44%. Comparing base (f005084) to head (355e81b).

Files Patch % Lines
paddlenlp/trainer/training_args.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8168      +/-   ##
===========================================
- Coverage    55.44%   55.44%   -0.01%     
===========================================
  Files          596      596              
  Lines        91464    91470       +6     
===========================================
  Hits         50713    50713              
- Misses       40751    40757       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit feb69cf into PaddlePaddle:develop Mar 22, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants