Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] shutil.rmtree ignore_errors for shared disks between train nodes. #8117

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Mar 14, 2024

PR types

Others

PR changes

Others

Description

Others

Copy link

paddle-bot bot commented Mar 14, 2024

Thanks for your contribution!

@ZHUI ZHUI changed the title Update trainer.py [BugFix] shutil.rmtree ignore_errors for shared disks between train nodes. Mar 14, 2024
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.46%. Comparing base (0a39fbf) to head (936c3c4).

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8117   +/-   ##
========================================
  Coverage    56.46%   56.46%           
========================================
  Files          596      596           
  Lines        91583    91583           
========================================
  Hits         51711    51711           
  Misses       39872    39872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 5fdc3c2 into develop Mar 14, 2024
9 of 12 checks passed
@ZHUI ZHUI deleted the ZHUI-patch-3 branch March 14, 2024 06:29
ZHUI added a commit that referenced this pull request Mar 14, 2024
[BugFix] shutil.rmtree ignore_errors for shared disks between train nodes. #8117
DesmonDay pushed a commit that referenced this pull request Mar 14, 2024
…odes #8117 (#8123)

[BugFix] shutil.rmtree ignore_errors for shared disks between train nodes. #8117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants