Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify_criterion_inputs_dynamic_and_static #8053

Conversation

liuzhenhai93
Copy link
Contributor

@liuzhenhai93 liuzhenhai93 commented Mar 5, 2024

PR types

Others

PR changes

Others

Description

crierion 动静半调用方式对齐

Copy link

paddle-bot bot commented Mar 5, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 56.51%. Comparing base (67f31c6) to head (133a744).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/auto_trainer.py 0.00% 35 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8053      +/-   ##
===========================================
- Coverage    56.53%   56.51%   -0.03%     
===========================================
  Files          592      592              
  Lines        91079    91114      +35     
===========================================
  Hits         51494    51494              
- Misses       39585    39620      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样改很多其他东西会break掉

liuzhenhai93 and others added 2 commits March 6, 2024 12:04
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@haohongxiang haohongxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit dd8a46c into PaddlePaddle:develop Mar 7, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants