Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Checkpoint] Fix multi-node output share-folder #7977

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix multi-node output share folder situation.

Copy link

paddle-bot bot commented Feb 6, 2024

Thanks for your contribution!

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (8d6e813) 56.58% compared to head (30af4fc) 56.57%.
Report is 3 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/plugins/unified_checkpoint.py 0.00% 12 Missing ⚠️
paddlenlp/trainer/training_args.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7977      +/-   ##
===========================================
- Coverage    56.58%   56.57%   -0.01%     
===========================================
  Files          589      589              
  Lines        89904    89913       +9     
===========================================
+ Hits         50871    50872       +1     
- Misses       39033    39041       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wawltor wawltor merged commit 7e643ad into PaddlePaddle:develop Feb 19, 2024
8 of 10 checks passed
DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants