修复NPU AICPU算子问题 #7976
Merged
修复NPU AICPU算子问题 #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7976 +/- ##
===========================================
- Coverage 56.58% 56.57% -0.01%
===========================================
Files 589 589
Lines 89910 89936 +26
===========================================
+ Hits 50872 50878 +6
- Misses 39038 39058 +20 ☔ View full report in Codecov by Sentry. |
ZHUI
approved these changes
Feb 7, 2024
| v=None, | ||
| sin=sin, | ||
| cos=cos, | ||
| position_ids=position_ids, |
There was a problem hiding this comment.
NPU和GPU的实现有点区别，NPU不需要这个参数，NPU的rope的融合算子只需要传入对应的tensor，sin和cos值即可
ZeyuChen
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.