Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified checkpoint] Turn off unified checkpoint when using sharding stage3 #7969

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

DesmonDay
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

Turn off unified checkpoint when using sharding stage3.

Copy link

paddle-bot bot commented Feb 5, 2024

Thanks for your contribution!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8d6e813) 56.58% compared to head (6bf0574) 56.58%.
Report is 1 commits behind head on develop.

❗ Current head 6bf0574 differs from pull request most recent head 5484994. Consider uploading reports for the commit 5484994 to get more accurate results

Files Patch % Lines
paddlenlp/trainer/training_args.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7969      +/-   ##
===========================================
- Coverage    56.58%   56.58%   -0.01%     
===========================================
  Files          589      589              
  Lines        89904    89910       +6     
===========================================
+ Hits         50871    50872       +1     
- Misses       39033    39038       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ZHUI
ZHUI previously approved these changes Feb 5, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit b312959 into PaddlePaddle:develop Feb 6, 2024
3 of 8 checks passed
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DesmonDay added a commit to DesmonDay/PaddleNLP that referenced this pull request Feb 6, 2024
wawltor pushed a commit that referenced this pull request Feb 6, 2024
…stage3 (#7969) (#7972)

* turn of uc when sharding stage3

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants