Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiGLU operator #7967

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Add SwiGLU operator #7967

merged 2 commits into from
Feb 20, 2024

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Feb 5, 2024

PR types

Performance optimization

PR changes

APIs

Description

Add SwiGLU operator to save memory and performance improvement.

Copy link

paddle-bot bot commented Feb 5, 2024

Thanks for your contribution!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7e643ad) 56.56% compared to head (8130a9e) 56.57%.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7967      +/-   ##
===========================================
+ Coverage    56.56%   56.57%   +0.01%     
===========================================
  Files          589      589              
  Lines        89939    89946       +7     
===========================================
+ Hits         50874    50887      +13     
+ Misses       39065    39059       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 20, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 20, 2024
@wawltor wawltor self-requested a review February 20, 2024 09:50
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 4eb6f0a into PaddlePaddle:develop Feb 20, 2024
7 of 10 checks passed
@sneaxiy sneaxiy deleted the add_swiglu branch February 20, 2024 09:50
@From00 From00 mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants