Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trainer] Skip some trainer test. #7949

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[Trainer] Skip some trainer test. #7949

merged 1 commit into from
Feb 5, 2024

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Feb 1, 2024

PR types

Others

PR changes

Others

Description

Others

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (9a31322) 56.68% compared to head (b38e757) 56.58%.
Report is 6 commits behind head on develop.

Files Patch % Lines
paddlenlp/trainer/integrations.py 69.86% 44 Missing ⚠️
paddlenlp/trainer/plugins/unified_checkpoint.py 0.00% 3 Missing ⚠️
paddlenlp/trainer/trainer.py 66.66% 2 Missing ⚠️
paddlenlp/trainer/plugins/timer.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7949      +/-   ##
===========================================
- Coverage    56.68%   56.58%   -0.10%     
===========================================
  Files          588      589       +1     
  Lines        89358    89907     +549     
===========================================
+ Hits         50651    50873     +222     
- Misses       38707    39034     +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI requested a review from DesmonDay February 4, 2024 09:30
Copy link

paddle-bot bot commented Feb 4, 2024

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit a33ab37 into develop Feb 5, 2024
8 of 12 checks passed
@ZHUI ZHUI deleted the tests/fix_uc branch March 20, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants