Add SearchApi integration #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
w5688414
reviewed
Feb 6, 2024
| @@ -239,3 +239,110 @@ def search(self, query: str, **kwargs) -> List[Document]: | |||
| logger.debug("Serper.dev API returned %s documents for the query '%s'", len(documents), query) | |||
| result_docs = documents[:top_k] | |||
| return self.score_results(result_docs, len(answer_box) > 0) | |||
|
|
|||
|
|
|||
| class SearchApi(SearchEngine): | |||
There was a problem hiding this comment.
Thank you. Add a unitest for your SearchApi?
There was a problem hiding this comment.
Thanks for the review. Do you have any example test cases that use real HTTP requests? Otherwise, running the pipeline examples might be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
Added SearchApi as a search engine provider. SearchApi provides engines such as Google, Google News, YouTube, and more.