-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] fix logger level #7903
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7903 +/- ##
===========================================
- Coverage 56.68% 56.68% -0.01%
===========================================
Files 588 588
Lines 89352 89354 +2
===========================================
- Hits 50651 50648 -3
- Misses 38701 38706 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他地方的 Print 还有没统一到 logger 的吗?
f" {model.__class__.__name__} from the checkpoint of a model that you expect to be exactly identical" | ||
" (initializing a BertForSequenceClassification model from a BertForSequenceClassification model)." | ||
) | ||
if logger.logger.level < 20: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<20,然后 warning,不太优雅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要为了保留warning的特征,否则就需要将warning降级为debug
目前仅修改了工具链中的相关信息,对齐过往交付的hack。其余位置没有检查。 |
主要指PaddleNLP包里面的,example的可以暂时不用考虑。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick of PaddlePaddle#7903
PR types
Improvement
PR changes
LLM
Description
fix logger level