Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] fix logger level #7903

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[Improvement] fix logger level #7903

merged 2 commits into from
Jan 29, 2024

Conversation

KB-Ding
Copy link
Contributor

@KB-Ding KB-Ding commented Jan 25, 2024

PR types

Improvement

PR changes

LLM

Description

fix logger level

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (13fd655) 56.68% compared to head (219403d) 56.68%.

❗ Current head 219403d differs from pull request most recent head 13f36d1. Consider uploading reports for the commit 13f36d1 to get more accurate results

Files Patch % Lines
paddlenlp/peft/lora/lora_model.py 0.00% 1 Missing ⚠️
paddlenlp/peft/prefix/prefix_model.py 0.00% 1 Missing ⚠️
paddlenlp/trainer/trainer.py 88.88% 1 Missing ⚠️
paddlenlp/trainer/trainer_callback.py 0.00% 1 Missing ⚠️
paddlenlp/transformers/model_utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7903      +/-   ##
===========================================
- Coverage    56.68%   56.68%   -0.01%     
===========================================
  Files          588      588              
  Lines        89352    89354       +2     
===========================================
- Hits         50651    50648       -3     
- Misses       38701    38706       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gongel gongel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他地方的 Print 还有没统一到 logger 的吗?

f" {model.__class__.__name__} from the checkpoint of a model that you expect to be exactly identical"
" (initializing a BertForSequenceClassification model from a BertForSequenceClassification model)."
)
if logger.logger.level < 20:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<20,然后 warning,不太优雅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要为了保留warning的特征,否则就需要将warning降级为debug

@KB-Ding
Copy link
Contributor Author

KB-Ding commented Jan 28, 2024

其他地方的 Print 还有没统一到 logger 的吗?

目前仅修改了工具链中的相关信息,对齐过往交付的hack。其余位置没有检查。

@gongel
Copy link
Member

gongel commented Jan 29, 2024

其他地方的 Print 还有没统一到 logger 的吗?

目前仅修改了工具链中的相关信息,对齐过往交付的hack。其余位置没有检查。

主要指PaddleNLP包里面的,example的可以暂时不用考虑。

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 9a31322 into PaddlePaddle:develop Jan 29, 2024
7 of 8 checks passed
KB-Ding added a commit to KB-Ding/PaddleNLP that referenced this pull request Jan 29, 2024
wawltor pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants