Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gqa fuse attention qkv #7890

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Jan 24, 2024

PR types

Others

PR changes

Others

Description

gqa fuse attention qkv

7B model, non_fuse vs fuse

a37aef3086e4c8df8d4de4640ab034f9

3.5B model, 4mp vs 8mp

image

Copy link

paddle-bot bot commented Jan 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (44bfeb0) 56.80% compared to head (5026243) 56.57%.
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7890      +/-   ##
===========================================
- Coverage    56.80%   56.57%   -0.23%     
===========================================
  Files          588      589       +1     
  Lines        89536    91330    +1794     
===========================================
+ Hits         50858    51674     +816     
- Misses       38678    39656     +978     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu closed this Jan 31, 2024
@FeixLiu FeixLiu reopened this Jan 31, 2024
@wawltor wawltor merged commit c0c64fa into PaddlePaddle:develop Feb 1, 2024
9 of 12 checks passed
@FeixLiu FeixLiu deleted the support_gqa_fusion branch February 1, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants