Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] aistudio, hf hub, bos update download #7608

Merged
merged 36 commits into from
Jan 4, 2024

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Dec 8, 2023

PR types

PR changes

Description

  1. 统一cache_dir的语义
  2. 修复auto系列加载
  3. 修复各种bug
  4. 加载文件先后顺序,本地文件,builtin文件,hf文件,aistudio文件,bos文件

Copy link

paddle-bot bot commented Dec 8, 2023

Thanks for your contribution!

@JunnYu JunnYu marked this pull request as ready for review December 26, 2023 01:48
@JunnYu JunnYu requested review from ZHUI and wj-Mcat December 26, 2023 01:49
@JunnYu JunnYu changed the title [WIP] aistudio, hf hub, bos update download [DONE] aistudio, hf hub, bos update download Dec 26, 2023
ZHUI
ZHUI previously approved these changes Dec 26, 2023
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (04dc625) 57.28% compared to head (76f9fd4) 57.41%.

Files Patch % Lines
paddlenlp/transformers/auto/image_processing.py 76.63% 25 Missing ⚠️
paddlenlp/transformers/auto/processing.py 82.60% 8 Missing ⚠️
paddlenlp/transformers/model_utils.py 86.27% 7 Missing ⚠️
paddlenlp/transformers/auto/modeling.py 82.75% 5 Missing ⚠️
paddlenlp/transformers/configuration_utils.py 85.71% 4 Missing ⚠️
paddlenlp/transformers/feature_extraction_utils.py 75.00% 4 Missing ⚠️
paddlenlp/generation/configuration_utils.py 76.92% 3 Missing ⚠️
paddlenlp/transformers/auto/configuration.py 88.23% 2 Missing ⚠️
paddlenlp/transformers/auto/tokenizer.py 86.66% 2 Missing ⚠️
paddlenlp/transformers/image_processing_utils.py 93.75% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7608      +/-   ##
===========================================
+ Coverage    57.28%   57.41%   +0.13%     
===========================================
  Files          584      585       +1     
  Lines        87729    87974     +245     
===========================================
+ Hits         50253    50511     +258     
+ Misses       37476    37463      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JunnYu JunnYu requested a review from ZHUI December 28, 2023 09:09
w5688414
w5688414 previously approved these changes Dec 29, 2023
Copy link
Contributor

@w5688414 w5688414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunnYu JunnYu requested a review from w5688414 December 29, 2023 07:31
ZHUI
ZHUI previously approved these changes Jan 2, 2024
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunnYu JunnYu dismissed stale reviews from ZHUI and w5688414 via 075fb0c January 2, 2024 03:59
@JunnYu JunnYu merged commit f93e7da into PaddlePaddle:develop Jan 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants