Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPT] Fix bugs #7141

Merged
merged 7 commits into from
Sep 28, 2023
Merged

[GPT] Fix bugs #7141

merged 7 commits into from
Sep 28, 2023

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Sep 27, 2023

PR types

Bug fixes

PR changes

Others

Description

Others

@paddle-bot
Copy link

paddle-bot bot commented Sep 27, 2023

Thanks for your contribution!

@ZHUI ZHUI changed the title [GPT-2] Fix bugs [GPT] Fix bugs Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #7141 (dbef5c2) into develop (0db85f7) will increase coverage by 0.05%.
The diff coverage is 76.82%.

@@             Coverage Diff             @@
##           develop    #7141      +/-   ##
===========================================
+ Coverage    59.56%   59.62%   +0.05%     
===========================================
  Files          563      563              
  Lines        82736    82666      -70     
===========================================
+ Hits         49284    49286       +2     
+ Misses       33452    33380      -72     
Files Coverage Δ
paddlenlp/dataaug/sentence.py 68.52% <100.00%> (ø)
paddlenlp/transformers/llama/modeling.py 68.45% <ø> (ø)
paddlenlp/transformers/gpt/modeling_pp.py 31.39% <0.00%> (ø)
paddlenlp/transformers/gpt/modeling.py 74.44% <77.21%> (+7.93%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 68bb39d into develop Sep 28, 2023
6 checks passed
@ZHUI ZHUI deleted the gpt2/fix_bugs branch September 28, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants