Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more argument settings for scheduler #6435

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

DesmonDay
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Support more argument settings for LR scheduler.

@paddle-bot
Copy link

paddle-bot bot commented Jul 19, 2023

Thanks for your contribution!

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #6435 (bcc0fbc) into develop (acfd537) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff            @@
##           develop    #6435   +/-   ##
========================================
  Coverage    63.18%   63.18%           
========================================
  Files          529      529           
  Lines        77201    77208    +7     
========================================
+ Hits         48779    48785    +6     
- Misses       28422    28423    +1     
Impacted Files Coverage Δ
paddlenlp/trainer/trainer.py 55.19% <ø> (ø)
paddlenlp/trainer/trainer_utils.py 44.04% <50.00%> (+0.06%) ⬆️
paddlenlp/trainer/training_args.py 60.35% <100.00%> (+0.30%) ⬆️

... and 2 files with indirect coverage changes

@wawltor wawltor merged commit 8dd0f6c into PaddlePaddle:develop Jul 19, 2023
4 checks passed
@DesmonDay DesmonDay deleted the add_more_scheduler_arg branch July 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants