Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERNIE vil2.0] Update image text retrieval data preprocessing #6251

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

qingzhong1
Copy link
Contributor

PR types

PR changes

Description

@paddle-bot
Copy link

paddle-bot bot commented Jun 26, 2023

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2023

CLA assistant check
All committers have signed the CLA.

@qingzhong1 qingzhong1 changed the title Update image text retrieval data preprocessing [ERNIE vil2.0] Update image text retrieval data preprocessing Jun 26, 2023
@w5688414 w5688414 self-requested a review June 26, 2023 12:11
model_zoo/ernie-vil2.0/data_util.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/data_util.py Outdated Show resolved Hide resolved
import numpy as np
import paddle
import pyarrow as pa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否需要增加requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经增加requirements.txt

model_zoo/ernie-vil2.0/data_util.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/data_util.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/data_util.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/extract_features.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/run_finetune.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/run_finetune.py Outdated Show resolved Hide resolved

python preprocess/create_lmdb_dataset.py \
python preprocess/create_arrow_dataset.py \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件在哪儿?create_arrow_dataset.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在ernie-vil2.0的preprocess文件夹中

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6251 (1e62be9) into develop (be11bf3) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6251      +/-   ##
===========================================
- Coverage    63.48%   63.35%   -0.14%     
===========================================
  Files          515      516       +1     
  Lines        73714    74305     +591     
===========================================
+ Hits         46800    47073     +273     
- Misses       26914    27232     +318     

see 24 files with indirect coverage changes

model_zoo/ernie-vil2.0/README.md Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/preprocess/create_arrow_dataset.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/extract_features.py Outdated Show resolved Hide resolved
model_zoo/ernie-vil2.0/extract_features.py Outdated Show resolved Hide resolved
Copy link
Contributor

@w5688414 w5688414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w5688414 w5688414 merged commit 44e5f84 into PaddlePaddle:develop Jun 28, 2023
@qingzhong1 qingzhong1 deleted the zq branch July 3, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants