Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos. #5709

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Fix some typos. #5709

merged 6 commits into from
Apr 24, 2023

Conversation

Yulv-git
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Fix some typos.

Signed-off-by: Yulv-git <yulvchi@qq.com>
Signed-off-by: Yulv-git <yulvchi@qq.com>
Signed-off-by: Yulv-git <yulvchi@qq.com>
Signed-off-by: Yulv-git <yulvchi@qq.com>
@paddle-bot
Copy link

paddle-bot bot commented Apr 18, 2023

Thanks for your contribution!

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

首先感谢您一次性给我们修了这么多typo!

这里大部分的修改都是很好的,ci不通过也不用介意,唯一的问题是对于markdown文件的提纲的修改,很多地方您改了提纲内容,但是没有改title的内容,会导致提纲的超链接不work

Comment on lines 5 to 14
- [1. 二分类/多分类简介](#二分类/多分类简介)
- [2. 快速开始](#快速开始)
- [2.1 运行环境](#运行环境)
- [2.2 代码结构](#代码结构)
- [2.3 数据准备](#数据准备)
- [2.4 模型训练](#模型训练)
- [2.5 模型预测](#模型预测)
- [2.6 模型效果](#模型效果)
- [二分类/多分类任务指南](#二分类多分类任务指南)
- [1. 二分类/多分类简介](#1-二分类多分类简介)
- [2. 快速开始](#2-快速开始)
- [2.1 运行环境](#21-运行环境)
- [2.2 代码结构](#22-代码结构)
- [2.3 数据准备](#23-数据准备)
- [2.4 模型训练](#24-模型训练)
- [2.4.1 预训练模型微调](#241-预训练模型微调)
- [2.4.2 训练评估](#242-训练评估)
- [2.4.3 模型裁剪(可选)](#243-模型裁剪可选)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

您这里修改了提纲内容,但是没有相应修改具体的title,会导致超链接出问题

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来如此,谢谢指导。是我这边 markdown 插件会对修过过的且存在目录的 .md 文件自动更新目录,而不是我手动修改对应的目录的。
已修改相关问题文件。

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #5709 (2eae3be) into develop (e33118a) will increase coverage by 1.39%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop    #5709      +/-   ##
===========================================
+ Coverage    60.30%   61.70%   +1.39%     
===========================================
  Files          486      487       +1     
  Lines        68968    68285     -683     
===========================================
+ Hits         41592    42133     +541     
+ Misses       27376    26152    -1224     
Impacted Files Coverage Δ
paddlenlp/layers/crf.py 51.26% <ø> (ø)
paddlenlp/metrics/glue.py 86.93% <ø> (ø)
paddlenlp/ops/optimizer/adamwdl.py 18.91% <ø> (ø)
paddlenlp/seq2vec/encoder.py 23.20% <ø> (ø)
...addlenlp/taskflow/multimodal_feature_extraction.py 84.21% <ø> (ø)
paddlenlp/taskflow/text_feature_extraction.py 90.47% <ø> (ø)
paddlenlp/transformers/bloom/processor.py 28.39% <ø> (ø)
paddlenlp/transformers/generation_utils.py 71.39% <ø> (+0.13%) ⬆️
paddlenlp/transformers/glm/modeling.py 60.65% <ø> (+1.81%) ⬆️
paddlenlp/transformers/model_outputs.py 95.43% <ø> (ø)
... and 16 more

... and 64 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

十分感谢帮助我们修改文档和注释!

@sijunhe sijunhe merged commit d030c63 into PaddlePaddle:develop Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants