Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPDiffusers] add lora rank option #4894

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Feb 20, 2023

PR types

PR changes

Description

@JunnYu JunnYu requested a review from sijunhe February 20, 2023 11:54
@paddle-bot
Copy link

paddle-bot bot commented Feb 20, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #4894 (ca5130d) into develop (50cd4cf) will increase coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4894      +/-   ##
===========================================
+ Coverage    44.64%   45.12%   +0.47%     
===========================================
  Files          446      447       +1     
  Lines        64373    64509     +136     
===========================================
+ Hits         28740    29107     +367     
+ Misses       35633    35402     -231     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 81.42% <0.00%> (-0.47%) ⬇️
paddlenlp/taskflow/task.py 51.62% <0.00%> (-0.37%) ⬇️
paddlenlp/transformers/mt5/modeling.py 84.37% <0.00%> (-0.31%) ⬇️
paddlenlp/transformers/__init__.py 100.00% <0.00%> (ø)
paddlenlp/transformers/auto/configuration.py 89.10% <0.00%> (ø)
paddlenlp/transformers/ernie/modeling.py 85.30% <0.00%> (+0.08%) ⬆️
paddlenlp/transformers/roberta/modeling.py 92.08% <0.00%> (+0.25%) ⬆️
paddlenlp/transformers/tokenizer_utils_base.py 79.23% <0.00%> (+0.29%) ⬆️
paddlenlp/transformers/utils.py 66.38% <0.00%> (+0.57%) ⬆️
paddlenlp/transformers/model_utils.py 78.66% <0.00%> (+1.29%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sijunhe sijunhe merged commit 5785d07 into PaddlePaddle:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants