Add the checkpoint for the pretrained model #195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wawltor
force-pushed
the
add_model_checkpoint
branch
from
cfc86a1 to
601d2ae
Compare
wawltor
force-pushed
the
add_model_checkpoint
branch
from
ed063b0 to
929d90d
Compare
ZeyuChen
requested changes
Mar 26, 2021
| model_to_save = model._layers if isinstance( | ||
| model, paddle.DataParallel) else model | ||
| model_to_save.save_pretrained(output_dir) | ||
| checkpoint.save_checkpoint(output_dir, global_step, |
There was a problem hiding this comment.
checkpoint.save_checkpoint的动作语义就不太自然
应该是model.save_checkpoint比较合理，理想的语义是代码即注释。
There was a problem hiding this comment.
感觉这里的搭配用法非常奇怪，既要model_to_save, 又要checkpoint.save
There was a problem hiding this comment.
这里的checkpoint主要是checkpoint optimizer和learning_rate，random相关状态
| @@ -0,0 +1,154 @@ | |||
| # coding:utf-8 | |||
There was a problem hiding this comment.
总感觉单独的checkpoint设计，脱离Trainer的考虑不是特别自然
There was a problem hiding this comment.
这里的checkpoint主要是checkpoint optimizer和learning_rate，random相关状态
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add the checkpoint for the pretrained model, those state will load from the checkpoint