Fix the usage of nltk bug #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyuChen
reviewed
Dec 27, 2021
| @@ -1641,6 +1641,8 @@ def _tokenize(self, text, is_sentencepiece=True): | |||
| text = convert_to_unicode(text) | |||
| text = " ".join(text.split()) # remove duplicate whitespace | |||
| nltk = try_import('nltk') | |||
There was a problem hiding this comment.
怎么可以再关键函数上反复try import呢，这些都得在初始化阶段去做
There was a problem hiding this comment.
已将nltk imort放到__init__函数中
|
nltk 在下载模型的时候会很慢很卡，这个地方是否评估过了？@joey12300 |
这里打开代理后下载就几秒，但是关了代理就要五六分钟，也没有输出进度条像是hang住一样。我把这条命令单独拿出来在README上说明一下 |
|
好的，争取今天内合入。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Description