Skip to content

[Hotfix] Hotfix for paddlenlp_ops installing on sm90 for sage attention #10493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

l1cacheDell
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

Copy link

paddle-bot bot commented Apr 24, 2025

Thanks for your contribution!

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.67%. Comparing base (f0c5aa2) to head (b3a6f0e).
Report is 1 commits behind head on develop.

❌ Your project check has failed because the head coverage (48.67%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10493   +/-   ##
========================================
  Coverage    48.67%   48.67%           
========================================
  Files          768      768           
  Lines       126915   126915           
========================================
+ Hits         61777    61779    +2     
+ Misses       65138    65136    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@vivienfanghuagood vivienfanghuagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

假如用户的/usr路径下安装了CUDA 12.3,但是pip安装了CUDA 12.6,会影响当前的判断吗?

@l1cacheDell
Copy link
Contributor Author

假如用户的/usr路径下安装了CUDA 12.3,但是pip安装了CUDA 12.6,会影响当前的判断吗?

如果用户的/usr路径下安装了CUDA 12.3,就不会安装sage attention,不管paddle的版本是否是12.6。因为nvcc 12.3 编译sage attention会报错。

@l1cacheDell l1cacheDell changed the title [Hotfix] Hotfix for paddlenlp_ops installing on sm90 for sag eattention [Hotfix] Hotfix for paddlenlp_ops installing on sm90 for sage attention Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants