[Hackathon 5th No.75] 新增模型InstructBlip #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LokeZhou
reviewed
Dec 18, 2023
LokeZhou
reviewed
Dec 18, 2023
There was a problem hiding this comment.
这个脚本与现有的base_processing.py有点重叠，且该定义在blip2_instruct_processing.py定义了，去掉该脚本
LokeZhou
reviewed
Dec 18, 2023
There was a problem hiding this comment.
该脚本的类名都带上blip2_instruct相关的字段，与现有的blip2做区分
LokeZhou
reviewed
Dec 18, 2023
There was a problem hiding this comment.
该脚本单独写到examples下，并配上相关readme.md说明文档
LokeZhou
reviewed
Dec 18, 2023
There was a problem hiding this comment.
该脚本与现有的base_model.py重叠，包括，要么修改成blip2_instruct_base_model.py,要么放到base_model.py里面
LokeZhou
reviewed
Dec 18, 2023
There was a problem hiding this comment.
该 脚本与blip2_opt2_instruct.py有什么区别或联系，能否合成一个脚本
|
LGTM + 对齐结果 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.