Add AnimeGANv2 model #102

zhen8838 · 2020-12-01T05:43:53Z

add AnimeGANv2 training and testing
add AnimeGANv2 apps
add AnimeGANv2 docs

add summary tool in utils
can get model structure like torchsummary

from ppgan.models.discriminators.discriminator_animegan import AnimeDiscriminator
from ppgan.utils.summary import summary
model = AnimeDiscriminator()
summary(model, (3, 256, 256))

CLAassistant · 2020-12-01T05:43:57Z

All committers have signed the CLA.

qingqing01

Excellent work! Thanks very much!

qingqing01 · 2020-12-01T14:57:03Z

docs/en_US/tutorials/animegan.md

+
+### 1.2.1 Prepare dataset
+
+We download the dataset provided by the author from [here](https://github.com/TachibanaYoshino/AnimeGAN/releases/download/dataset-1).Then unzip to the `data` directory.


https://github.com/TachibanaYoshino/AnimeGAN/releases/download/dataset-1 is a dead link, should be

https://github.com/TachibanaYoshino/AnimeGAN/releases/tag/dataset-1

Better to give download command:

wget https://github.com/TachibanaYoshino/AnimeGAN/releases/download/dataset-1/dataset.zip

qingqing01 · 2020-12-01T15:00:10Z

docs/en_US/tutorials/animegan.md

+  **NOTE：** you must modify the `configs/animeganv2.yaml > pretrain_ckpt ` parameter first! ensure the GAN can reuse the warmup generator model.
+  ```sh
+  python tools/main.py --config-file configs/animeganv2.yaml
+  ```


Add the training hyper params in doc to tell users how to reproduce the results. For example, how many GPU used? training step, batch-size, lr... can refer config. and so on.

qingqing01 · 2020-12-01T15:01:18Z

docs/en_US/tutorials/animegan.md

+python tools/main.py --config-file configs/animeganv2.yaml --evaluate-only --load ${PATH_OF_WEIGHT}
+```
+
+## 1.3 结果展示


结果展示 -> Results

qingqing01 · 2020-12-01T15:02:43Z

ppgan/apps/animegan_predictor.py

@@ -0,0 +1,73 @@
+import os


Maybe also can add copyright, and add author zhen8838 after copyright. same as below

qingqing01 · 2020-12-01T15:05:20Z

ppgan/datasets/transforms/functional.py

+    Iterable = collections.Iterable
+else:
+    Sequence = collections.abc.Sequence
+    Iterable = collections.abc.Iterable


remove the unsed importing, like Image, sin, cos, tan, .. collections...

qingqing01 · 2020-12-01T15:06:16Z

ppgan/datasets/transforms/functional_cv2.py

+
+
+def add(image, value):
+    return np.clip(image + value, 0, 255).astype('uint8')


It seems only needs functional.py

qingqing01 · 2020-12-01T15:08:00Z

ppgan/datasets/transforms/transforms.py

+
+@TRANSFORMS.register()
+class Add(T.BaseTransform):
+    def __init__(self, value, keys=None):


Better to add commens. Although, there is no comments in the existing code. We will add in future

qingqing01 · 2020-12-01T15:10:30Z

ppgan/models/animeganv2_model.py

+from ..solver import build_optimizer
+from ..modules.init import init_weights
+from ..utils.filesystem import load
+from paddle import nn


put this line in second line.

system importing, then third-party lib importing, then locally importing

qingqing01 · 2020-12-01T15:12:21Z

ppgan/models/generators/generater_animegan.py

+        return x
+
+
+class resBlock(nn.Layer):


resBlock -> ResBlock

LielinJiang · 2020-12-02T02:39:18Z

ppgan/utils/summary.py

+import numpy as np
+
+
+def summary(model, input_size, batch_size=-1):


try paddle.summary

zhen8838 · 2020-12-02T11:00:47Z

Thanks for the review😝, I have made the following changes in the new commit:

fix docs bug, add more details
add copyright in each file
In order to follow the original paddlepaddle transform design, I still keep functional_cv2.py
add some comments in transforms.py
modify the import order, rename resBlock
remove custom summary.py

qingqing01 · 2020-12-02T12:51:15Z

@zhen8838 There is conflict. And we are do testing now. Will be merged after passing the testing.

zhen8838 added 4 commits November 29, 2020 15:20

add animeganv2 network and dataset

e39bb2b

add animeganv2 model

c02c624

add animeganv2 infer

9c9bada

Add AnimeGAN v2 model

99fea44

qingqing01 requested review from LielinJiang, lijianshe02, qingqing01, wanghaoshuang and ceci3 December 1, 2020 14:50

qingqing01 reviewed Dec 1, 2020

View reviewed changes

LielinJiang reviewed Dec 2, 2020

View reviewed changes

animegan:refine code,add License

cfc2909

Merge branch 'master' into animeganv2

c04b177

qingqing01 approved these changes Dec 5, 2020

View reviewed changes

qingqing01 merged commit 10de3c6 into PaddlePaddle:master Dec 5, 2020

zhen8838 deleted the animeganv2 branch December 9, 2020 11:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AnimeGANv2 model #102

Add AnimeGANv2 model #102

zhen8838 commented Dec 1, 2020

CLAassistant commented Dec 1, 2020 •

edited

Loading

qingqing01 left a comment

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020 •

edited

Loading

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020

qingqing01 Dec 1, 2020 •

edited

Loading

qingqing01 Dec 1, 2020

LielinJiang Dec 2, 2020

zhen8838 Dec 2, 2020

zhen8838 commented Dec 2, 2020

qingqing01 commented Dec 2, 2020


		### 1.2.1 Prepare dataset

		We download the dataset provided by the author from [here](https://github.com/TachibanaYoshino/AnimeGAN/releases/download/dataset-1).Then unzip to the `data` directory.



		def add(image, value):
		return np.clip(image + value, 0, 255).astype('uint8')

		import numpy as np


		def summary(model, input_size, batch_size=-1):

Add AnimeGANv2 model #102

Add AnimeGANv2 model #102

Conversation

zhen8838 commented Dec 1, 2020

CLAassistant commented Dec 1, 2020 • edited Loading

qingqing01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingqing01 Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingqing01 Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhen8838 commented Dec 2, 2020

qingqing01 commented Dec 2, 2020

CLAassistant commented Dec 1, 2020 •

edited

Loading

qingqing01 Dec 1, 2020 •

edited

Loading

qingqing01 Dec 1, 2020 •

edited

Loading