[Custom Device] modefy pool2d signature from int32 to int64 #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
LittleHeroZZZX
changed the title
| std::vector<int> strides_t = | ||
| std::vector<int>(strides_t_64.begin(), strides_t_64.end()); | ||
| std::vector<int> paddings_t = | ||
| std::vector<int>(paddings_t_64.begin(), paddings_t_64.end()); |
Collaborator
There was a problem hiding this comment.
这里如果不转，直接传给gcu 会有问题吗
xiaoguoguo626807
approved these changes
May 26, 2025
xiaoguoguo626807
merged commit 833ebc6
into
PaddlePaddle:develop
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
与主仓 PaddlePaddle/Paddle#72639 同步，修改 pool2d 的参数为
std::vector<int64_t>