Skip to content

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Apr 11, 2018

As we use NCCL2 now, we could remove NCCL1 related code, such as nccl.cmake.
fix #8504
fix #8195
fix #6877
fix #5035

@luotao1 luotao1 requested a review from dzhwinter April 11, 2018 06:47
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit b45776a into PaddlePaddle:develop Apr 11, 2018
@luotao1 luotao1 deleted the nccl branch April 11, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants